fix: prevent panic when parsing a URL with no path #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to make changes if I got anything wrong! |
Prior to this change `parse` would panic at `src/lib.rs:203:29` with `index out of bounds: the len is 0 but the index is 0` if given an input like "git:".
This removes a seemingly redundant and not very illuminating error variant. It also ensures that the error message from the `Url` crate is displayed when displaying `UrlParseError`.
CardboardTurkey
force-pushed
the
fix/parse-panic
branch
from
52e6386 to
f87f247
Compare
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3 new commits:
chore: sate clippy
Fix clippy lints
fix: prevent panic when parsing a URL with no path
Prior to this change
parsewould panic atsrc/lib.rs:203:29withindex out of bounds: the len is 0 but the index is 0if given an inputlike "git:".
feat: improve error handling
This removes a seemingly redundant and not very illuminating error
variant. It also ensures that the error message from the
Urlcrate isdisplayed when displaying
UrlParseError.